Fixes yield proc scheduling. Turns sleeps into an opcode #1539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cyberboss
force-pushed
the
1262-SmartYield
branch
from
0bb5985 to
4f0b534
Compare
Cyberboss
commented
Nov 27, 2023
Comment on lines
+55
to
+58
| rand_seed(22475) | ||
| for(var/i in 1 to 10000) | ||
| world.log << "Rand-[i]:" | ||
| TestSequence(MODE_RAND) |
There was a problem hiding this comment.
Had to up the test timeout because this overran 500ms
|
Apparently this is still unperformant for the issue in question |
- Remove `sleep` from DMStandard. - Two new opcodes Sleep and BackgroundSleep (which is just `sleep -1`, much faster than popping a `float` off for background sleeps). - Create new lightweight async proc state for sleeping. - Compiler/runtime adjustments to handle new opcodes.
Cyberboss
force-pushed
the
1262-SmartYield
branch
from
750403d to
86fb394
Compare
Cyberboss
changed the title
Cyberboss
commented
Jan 1, 2024
DMCompiler/DM/DMProc.cs
Outdated
| public void SleepDelayPushed() => WriteOpcode(DreamProcOpcode.Sleep); | ||
|
|
||
| public void Sleep(float delay) { | ||
| if(delay == -1.0f) // yielding |
|
Somethings still fucky, which is why the TGS tests are failing |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
boring-cyborg
bot
added
Client
Cyberboss
force-pushed
the
1262-SmartYield
branch
from
66dddbc to
38e1ff4
Compare
Merged
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behavior is now the same for either
spawnorsleep:delay < 0: Proc will continue immediately if nothing is scheduled in the same tick. Otherwise, same asdelay == 0.delay == 0: Proc scheduled on end of same tick.delay > 0: Proc scheduled afternticks.This also fixes the ProcScheduler being able to still have queued procs when running multiple tests in serial.
Then, to fix perf issues I had to redo sleeping into an opcode:
sleepfrom DMStandard.SleepandBackgroundSleep(which is justsleep -1, much faster than popping afloatoff for background sleeps).IOpenDreamGameTimingas a wrapper aroundIGameTimingthat we can control in unit tests.Closes #1262